admin/omsorg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix infinite redirect loop on omsorgWeb behind the TLS-terminating proxy
Docker-Images bauen und veröffentlichen / build (, omsorgCore/Dockerfile, omsorgcore) (push) Successful in 3s
Details
Docker-Images bauen und veröffentlichen / build (, omsorgWeb/Dockerfile, omsorgweb) (push) Successful in 4s
Details
Docker-Images bauen und veröffentlichen / build (, omsorgapp/Dockerfile, omsorgapp) (push) Successful in 3s
Details

Browse Source 
The root .htaccess forces HTTPS via `RewriteCond %{HTTPS} !=on`. Behind a
reverse proxy that terminates TLS and forwards to Apache over plain HTTP,
%{HTTPS} is always "off" - verified via mod_rewrite trace logging that
this is NOT spoofable via SetEnvIf or a RewriteRule E-flag, despite that
being commonly recommended; %{HTTPS} reflects only the actual TLS
connection to Apache. Every request was therefore redirected to https://,
which the proxy forwarded back over HTTP, looping forever (browser: "the
page isn't redirecting properly").

Fix: .htaccess's redirect condition also accepts a trusted
X-Forwarded-Proto: https header as evidence the request is already
HTTPS. omsorgWeb/docker/000-default.conf additionally sets HTTPS=on in
the request environment when that header is present, so mod_headers'
`env=HTTPS` condition (HSTS header) still fires correctly - this part
doesn't affect mod_rewrite's %{HTTPS} but is unrelated to the redirect fix.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Felix Kemmler
2026-08-10 18:37:06 +02:00
co-authored by Claude Sonnet 5
parent dcc8ea1510
commit 0d767d7edf
3 changed files with 38 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
omsorgWeb/docker/000-default.conf
+22
View File
@@ -0,0 +1,22 @@
<VirtualHost *:80>
ServerName omsorgweb
ServerAdmin webmaster@localhost
DocumentRoot /var/www/html
# Der Host-nginx terminiert TLS und proxied per HTTP an diesen Container (siehe
# docker-compose.yml) - ohne diese Regel weiß die root-.htaccess
# (`RewriteCond %{HTTPS} !=on` -> Redirect auf https://) nie, dass die ursprüngliche Anfrage
# HTTPS war, und redirected endlos (führt zu "Firefox kann nicht verbinden - Seite leitet
# falsch weiter" bzw. ERR_TOO_MANY_REDIRECTS). Per mod_rewrite-Trace verifiziert: das MUSS
# innerhalb dieses <VirtualHost>-Blocks stehen - weder eine Regel in conf-enabled/*.conf
# außerhalb jedes VirtualHost, noch eine in einem <Directory>-Block wird mit dem
# per-Directory-Regelsatz der .htaccess desselben Pfads zusammengeführt (beides per Trace
# ausprobiert, keins hat gewirkt - Apache vererbt Rewrite-Regeln standardmäßig nicht über
# Kontextgrenzen hinweg, siehe RewriteOptions Inherit in der mod_rewrite-Doku).
RewriteEngine On
RewriteCond "%{HTTP:X-Forwarded-Proto}" "=https"
RewriteRule ^ - [E=HTTPS:on]
ErrorLog ${APACHE_LOG_DIR}/error.log
CustomLog ${APACHE_LOG_DIR}/access.log combined
</VirtualHost>